When You're Smiling

"When You're Smiling"
Song
Published 1928 by Mills Music
Songwriter(s) Larry Shay, Mark Fisher, Joe Goodwin

"When You're Smiling" is a popular song written by Larry Shay, Mark Fisher and Joe Goodwin. First published in 1928, it bears resemblance to the Spanish Canción "Amapola" by José María Lacalle García. Early popular recordings were by Seger Ellis (1928), Louis Armstrong (1929), and Ted Wallace & His Campus Boys (1930).

The lyrics and music of the song entered the public domain in the United States in 2024.

Other recordings

Billie Holiday, here depicted in February 1947, recorded this song on 6 January 1938 with Teddy Wilson & His Orchestra.

See also